feat: add app_metadata to rust sync requests #151
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Nov 26, 2025
simolus3
approved these changes
Nov 26, 2025
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
We need someone else to approve this now, but I'm happy with these changes 👍
Should we wait for the service changes to land first?
Contributor
Author
Thanks! Indeed, this can wait for the service changes, however if we are planning on doing a core release before those service changes are released - I think we could progress with this. I can't really imagine many other methods of passing this metadata to the service. |
rkistner
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This passes
app_metadataprovided by the client to Sync stream request payloads.